Skip to content

Conversation

@HechtiDerLachs
Copy link
Collaborator

This is none of my business, really, but since Alheydis raised an issue about realization spaces on Slack, I thought, I might just try to provide a fix. The problem did not seem to be very mathematical, so I could get it to run and produce some result. However, since this is not my field of expertise, I can not verify myself that whatever I did here is mathematically correct!

Maybe @bschroter and friends can have a quick look and confirm? Or intervene, please!

@HechtiDerLachs
Copy link
Collaborator Author

The failing tests suggest that I did something which was not mathematically legitimate. Maybe this can still be helpful for people who know the matroid realization space code? Otherwise, feel free to close this!

@HechtiDerLachs HechtiDerLachs marked this pull request as draft November 12, 2025 01:18
@AlheydisGeiger
Copy link
Contributor

Hi, thanks for looking into it! The output that you sent to me on Slack looks reasonable. The printing of the number of variables appearing in the base ring is not ideal though, since the realization space is 0 dimensional. So there should be no variable x1 and no avoidance loci.

@joschmitt joschmitt requested a review from bschroter November 12, 2025 11:56
@joschmitt
Copy link
Member

CC @LukasKuehne

@HechtiDerLachs
Copy link
Collaborator Author

Tests look better now. Looks like this PR can be taken more serious, then?

@HechtiDerLachs HechtiDerLachs marked this pull request as ready for review November 12, 2025 16:07
@HechtiDerLachs
Copy link
Collaborator Author

So there should be no variable x1 and no avoidance loci.

This might be an issue. I think we do not allow for creation of polynomial rings with zero variables. But the people working on the realization spaces might have another catch for that, I don't know...

@joschmitt
Copy link
Member

So there should be no variable x1 and no avoidance loci.

This might be an issue. I think we do not allow for creation of polynomial rings with zero variables. But the people working on the realization spaces might have another catch for that, I don't know...

You can create polynomial rings with zero variables (for example, polynomial_ring(QQ, 0, :x) works).

@LukasKuehne
Copy link
Contributor

So there should be no variable x1 and no avoidance loci.

This might be an issue. I think we do not allow for creation of polynomial rings with zero variables. But the people working on the realization spaces might have another catch for that, I don't know...

Hi,
Can you briefly copy the issue you're trying to solve here (I didn't see the original post on slack)?
So far I think we returned different rings, either a polynomial ring or just a field/ZZ if there are no variables. Is it that you're trying to fix?

@joschmitt
Copy link
Member

The issue is the following error:

julia> r = matroid_from_bases([[3,5],[3,4],[2,5],[2,4]],5)
Matroid of rank 2 on 5 elements

julia> realization_space(r,char=0)
ERROR: ArgumentError: reducing over an empty collection is not allowed; consider supplying `init` to the reducer
[...]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants