-
Notifications
You must be signed in to change notification settings - Fork 162
Some inits for realization spaces #5539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Some inits for realization spaces #5539
Conversation
|
The failing tests suggest that I did something which was not mathematically legitimate. Maybe this can still be helpful for people who know the matroid realization space code? Otherwise, feel free to close this! |
|
Hi, thanks for looking into it! The output that you sent to me on Slack looks reasonable. The printing of the number of variables appearing in the base ring is not ideal though, since the realization space is 0 dimensional. So there should be no variable x1 and no avoidance loci. |
|
CC @LukasKuehne |
|
Tests look better now. Looks like this PR can be taken more serious, then? |
This might be an issue. I think we do not allow for creation of polynomial rings with zero variables. But the people working on the realization spaces might have another catch for that, I don't know... |
You can create polynomial rings with zero variables (for example, |
Hi, |
|
The issue is the following error: |
This is none of my business, really, but since Alheydis raised an issue about realization spaces on Slack, I thought, I might just try to provide a fix. The problem did not seem to be very mathematical, so I could get it to run and produce some result. However, since this is not my field of expertise, I can not verify myself that whatever I did here is mathematically correct!
Maybe @bschroter and friends can have a quick look and confirm? Or intervene, please!